Fixed transparent Color constant. #1949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Minor <[email protected]>
jminor
force-pushed
the
transparent-fix
branch
from
3270bc5 to
10fe904
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes. Additional details and impacted files@@ Coverage Diff @@
## main #1949 +/- ##
==========================================
+ Coverage 84.11% 85.00% +0.88%
==========================================
Files 198 181 -17
Lines 22241 13074 -9167
Branches 4687 1206 -3481
==========================================
- Hits 18709 11113 -7596
+ Misses 2610 1778 -832
+ Partials 922 183 -739
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 139 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
darbyjohnston
merged commit 00515e2
into
AcademySoftwareFoundation:main
63 of 69 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1948
The
transparentconstant Color had incorrect RGB values (1,1,1,0). This PR updates that to (0,0,0,0).